clearing more state #609
Merged
clearing more state #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
approved these changes
Dec 15, 2021
Yes the inclusion of that test from Ger's older pr added state into the IngressControllerManager. I get that it's speedier for quarkus to not restart for each test, but it seems kind of burdensome for our style of application that doesn't have alternative scopes like session/request. |
MikeEdgar
reviewed
Dec 15, 2021
operator/src/test/java/org/bf2/operator/managers/IngressControllerManagerTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #607 - we need to always cleanup state held by beans as well as the mock server to have a clean slate for other tests.