Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a stub function for bfast0n #56

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Create a stub function for bfast0n #56

merged 3 commits into from
Jun 2, 2020

Conversation

GreatEmerald
Copy link
Collaborator

@GreatEmerald GreatEmerald commented May 1, 2020

Initial implementation of the bfast0n function.
Fixes #20

@GreatEmerald GreatEmerald added the wip Work in progress - do not merge yet label May 1, 2020
@GreatEmerald
Copy link
Collaborator Author

GreatEmerald commented May 1, 2020

Fixes #20

@GreatEmerald GreatEmerald removed the wip Work in progress - do not merge yet label May 13, 2020
@GreatEmerald
Copy link
Collaborator Author

The basics should work now, testing welcome.

There is one issue in that it displays the index of the change in the bfastpp object, but we don't keep it around, so we don't actually know when the change happened. This can be fixed either via bfast2/strucchangeRcpp#15 or by returning both the bfastpp and the breakpoints object. I prefer the former because the bfastpp object by itself is not really that interesting for users. A yet another approach that doesn't depend on strucchange is to do extra parsing in the function of the bfastpp object and then modify the breakpoints result to show the correct corresponding date.

@github-actions
Copy link

Due to lack of activity on this pull request, it may now be merged without review.

@github-actions github-actions bot added the stale No recent activity, therefore will be merged automatically label May 28, 2020
@GreatEmerald
Copy link
Collaborator Author

Tested and it seems to work. For the issue, let's discuss in the corresponding issue.

@GreatEmerald GreatEmerald merged commit 1c88bdb into master Jun 2, 2020
@GreatEmerald GreatEmerald deleted the 20-bfast0n branch June 2, 2020 09:43
@GreatEmerald GreatEmerald removed the stale No recent activity, therefore will be merged automatically label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a bfast0n() method (breakpoints()-based) - multiple breakpoints
1 participant