Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish decompiling zTaxi & mark it as equivalent #278

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

tgsm
Copy link
Contributor

@tgsm tgsm commented Jun 25, 2024

No description provided.

@mattbruv mattbruv merged commit ff79744 into bfbbdecomp:main Jun 25, 2024
1 check passed
@tgsm tgsm deleted the finish-zTaxi branch June 25, 2024 13:53
@@ -48,7 +48,8 @@ struct ztalkbox : xBase
{
ANSWER_CONTINUE,
ANSWER_YES,
ANSWER_NO
ANSWER_NO,
ANSWER_3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably just call this ANSWER_NUM, though it's somewhat confusing to me that this enum definition in the dwarf doesn't have this value. Possibly sAnswer was just defined as ztalkbox::ANSWER_NO + 1 but that's also pretty strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants