Finish matching xSurface #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SquareMan
reviewed
Jun 27, 2024
Comment on lines
+26
to
29
| extern "C" { | ||
| extern void __copy(void* dst, const void* src, uint32 n); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should this be declared in intrin.h?
There was a problem hiding this comment.
I'm not sure. It doesn't get replaced with an instruction like the other intrinsics do, and it's implemented in the runtime library.
There was a problem hiding this comment.
I don't know either. I don't think it's something that's supposed to be directly included though. The whole assignment function was probably compiler generated, with the default implementation being to call __copy for any arrays. I suppose this fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.