Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match zMusicUnpause #391

Merged
merged 1 commit into from
Oct 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 24 additions & 28 deletions src/SB/Game/zMusic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ void zMusicInit()
volume_reset();
}

// Correct, but won't work due to the switch case jump table (messes with offsets)
S32 getCurrLevelMusicEnum()
static S32 getCurrLevelMusicEnum()
{
S32 snd_enum;

Expand Down Expand Up @@ -247,39 +246,36 @@ void zMusicPause()
}
}

// WIP.
#if 0
// Only thing that doesn't compile correctly is the function call to xSndPlay, in which a bunch of stuff is in the wrong order it looks like.
void zMusicUnpause(S32 kill)
{
if (sMusicPaused != 0)
if (sMusicPaused == 0)
{
for (S32 i = 0; i < 2; i++)
return;
}

for (S32 i = 0; i < 2; i++)
{
zMusicTrackInfo* track = &sMusicTrack[i];
if (track->snd_id == 0)
{
zMusicTrackInfo* track = &sMusicTrack[i];
U32 prioBase = 0x800 * i;
if (track->snd_id != 0)
{
if (kill != 0)
{
track->snd_id = 0;
}
else
{
U32 res =
xSndPlay(track->assetID, track->lastVol, lbl_803CDD48, 0xff,
prioBase | (int)(-track->loop | track->loop) >> 0x1f & 0x8000U |
0x10000 | 0x20000,
0, SND_CAT_MUSIC, lbl_803CDD48);
track->snd_id = res;
}
}
continue;
}

if (kill != 0)
{
track->snd_id = 0;
}
else
{
S32 flags = i * 0x800;
flags |= ((track->loop != 0) ? 0x8000 : 0) | 0x10000;
flags |= 0x20000;
track->snd_id = xSndPlay(track->assetID, track->lastVol, 0.0f, 0xff, flags, 0, SND_CAT_MUSIC, 0.0f);
}
sMusicPaused = 0;
}
}

#endif
sMusicPaused = 0;
}

// WIP.
#if 0
Expand Down
1 change: 0 additions & 1 deletion src/SB/Game/zMusic.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ struct zMusicTrackInfo

void volume_reset();
void zMusicRefreshVolume();
S32 getCurrLevelMusicEnum();
void zMusicNotify(S32 situation);
void zMusicSetVolume(F32 vol, F32 delay);
void zMusicKill();
Expand Down