Remove criterion template header from upgrade, these have no connecti…

…on to the vb instance.
bfh · Dec 4, 2024 · 94c3e37 · 94c3e37
1 parent 8590c4d
commit 94c3e37
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/db/upgrade.php b/db/upgrade.php
@@ -155,12 +155,11 @@ function add_instance_to_localized_string() {
     foreach ($results as $result) {
         $DB->execute(
             sprintf('UPDATE {%s} SET instanceid = ?
-            WHERE foreignkey = ? AND typeid IN (?, ?)', tables::LOCALIZED_STRING_TABLE),
+            WHERE foreignkey = ? AND typeid = ?', tables::LOCALIZED_STRING_TABLE),
             [
                 $result->instanceid,
                 $result->id,
                 localized_string_type::str2id(localized_string_type::INSTANCE_CRITERION),
-                localized_string_type::str2id(localized_string_type::TEMPLATE_CRITERION),
             ]
         );
     }