Skip to content

Commit

Permalink
Remove the setting: fallbackspantag
Browse files Browse the repository at this point in the history
- It was not observed correctly (markup in the editor is still
  applied even if the setting was off).
- Correcting the first point would have leed to no styling which
  is somewhat awkward when there are <span class="multilang">
  tags contained in the text but not marked as such (because
  of the setting being disabled).

Therefore the <span> tag is now the default behaviour when there
is no multilang filter 2 installed.
  • Loading branch information
srobotta committed Sep 26, 2023
1 parent 97cfb98 commit dc4a96a
Show file tree
Hide file tree
Showing 14 changed files with 8 additions and 39 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ is enabled, the standard `<span class="multilang">` tags are used.

If the language selection does not appear in the editor:
- Check that the [multilang2 filter][1] is installed and enabled.
- If you don't use the [multilang2 filter][1], check that the setting `fallbackspantag` is active.
- Check that your site has at least two languages installed.
- If you don't have more than one language installed, enable the `addlanguage` option and
set a few language iso codes in the `languageoptions` setting.
Expand Down Expand Up @@ -88,8 +87,7 @@ transformed into the standard Moodle annotation is used. These are span elements
and the `dir` attribute annotates whether this is a left to right language or vice versa.

When loading a text, both annotations are read and translated into marked language tags in the
WYSIWYG mode, if the setting `fallbackspantag` is enabled. Otherwise, the Moodle default
span tags are ignored. If mixed annotations are used in the text, these are preserved upon
WYSIWYG mode. If mixed annotations are used in the text, these are preserved upon
saving.

### Possible languages options
Expand Down
4 changes: 2 additions & 2 deletions amd/build/options.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion amd/build/options.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit dc4a96a

Please sign in to comment.