Aave Swapper - TWAP Orders #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+166
to
+167
| address handler, | ||
| address relayer, |
There was a problem hiding this comment.
@efecarranza does it make sense to make these params as immutable?
There was a problem hiding this comment.
hey @brotherlymite when building the original AaveSwapper, feedback was provided that we should be allowed to pass the specific price checker, so that's why I went with that route for this even though they are not a price checker, but kind of the same concept. We could have it as a contract variable that can be updated as well in case of changes to the cow swap relayer or handler, though I doubt those values are likely to change.
@eboado If my memory serves me well, I think you and I had discussed this approach. Wanted to see if you had any thoughts around it. Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add TWAP orders to the Aave Swapper contract.
Add tests for TWAP orders.
Add documentation to README.
Builds on top of: #201