Gauntlet Aave V3 Ava Recommendations #18
Conversation
| 0x4365F8e70CF38C6cA67DE41448508F2da8825500; | ||
|
|
||
| function setUp() public { | ||
| vm.createSelectFork(vm.rpcUrl("avalanche"), 18805477); |
There was a problem hiding this comment.
I think you are forking from too much in the past. Better to use a fresher Avalanche block
There was a problem hiding this comment.
Because the --fork-block-number 21789453 from CLI will be factually ignored (pretty sure)
| address public constant GUARDIAN_AVALANCHE = | ||
| 0xa35b76E4935449E33C56aB24b23fcd3246f13470; | ||
|
|
||
| address public constant CURRENT_ACL_SUPERADMIN = |
There was a problem hiding this comment.
Not required, the GUARDIAN_AVALANCHE has all the necessary permissions to send the risk_admin role
|
@reem could you also add to the README the new steward? |
|
|
||
| uint256 constant NUM_UPDATES = 5; | ||
|
|
||
| struct Updates { |
There was a problem hiding this comment.
Of course, it works and is correct, but I wonder why you decided to declare this way instead of returning in _getUpdates() a ParameterSet[] memory
|
Updated for your comments, thanks. The |
Creates a new steward contract that can be used to implement risk parameter updates to Aave V3 Ava markets, also adds tests and deploy scripts for the contract. This contract can be edited and used for future risk updates as well.
My solidity is alright but certainly not as strong as y'alls so very much interested in feedback on how to improve the contract if you have any!