Add TransparentProxyFactoryBase #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendra
reviewed
Jul 25, 2024
| @@ -15,7 +12,7 @@ import {ProxyAdmin} from '../../../src/contracts/transparent-proxy/ProxyAdmin.so | |||
| * @dev Highly recommended to pass as `admin` on creation an OZ ProxyAdmin instance | |||
| * @dev This contract needs solc=0.8.19 and zksolc=1.4.1 as codeHashes are specifically made for those versions | |||
| **/ | |||
| contract TransparentProxyFactoryZkSync is ITransparentProxyFactoryZkSync { | |||
| contract TransparentProxyFactoryZkSync is TransparentProxyFactoryBase { | |||
There was a problem hiding this comment.
missing here ITransparentProxyFactoryZkSync i guess with only the constants defined there
sendra
approved these changes
Jul 25, 2024
sendra
added a commit
that referenced
this pull request
Jul 25, 2024
* feat: update proxy factory to zksync * fix: added correct hashes for v0.8.19 * fix: added hashes with 1.5.0 * fix: 1.4.1 hashes * fix: sepparate zksync contracts * fix: added zksync configs * fix: separate zksync contracts to specific profile * fix: fixed missing conflict * fix: removed fixed version * fix: remove not needed diffs * fix: prettier * fix: added correct profiles * Add TransparentProxyFactoryBase (#37) * Add TransparentProxyFactoryBase * cleanup ITransparentProxyFactoryZkSync --------- Co-authored-by: sendra <[email protected]> Co-authored-by: Andrey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.