Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass in a pixel value instead of a DP value for header elevation to match consistency with Android's
View.setElevation()
method and to allow clients to use a value from their app'sdimens
file so that elevation dimensions can be reused/standardized more easily.Remove
elevateHeaders()
to avoid differing behaviors for calling bothelevateHeaders()
andsetHeaderElevation()
. For example, as a client, is settingsetHeaderElevation(0)
the same as `elevateHeaders(false)? Exposing only one method to add or remove elevation avoids the confusion and potential conflicting behavior outcomes.Remove the
cachedElevation
field and elevation resolution helper methods since they're no longer necessary.