Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header elevation pixels #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ryandt
Copy link

@ryandt ryandt commented Feb 2, 2020

  • Pass in a pixel value instead of a DP value for header elevation to match consistency with Android's View.setElevation() method and to allow clients to use a value from their app's dimens file so that elevation dimensions can be reused/standardized more easily.

  • Remove elevateHeaders() to avoid differing behaviors for calling both elevateHeaders() and setHeaderElevation(). For example, as a client, is setting setHeaderElevation(0) the same as `elevateHeaders(false)? Exposing only one method to add or remove elevation avoids the confusion and potential conflicting behavior outcomes.

  • Remove the cachedElevation field and elevation resolution helper methods since they're no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant