[stayrtr] add hash check on slurm data #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjeker
suggested changes
Feb 29, 2024
cmd/stayrtr/stayrtr.go
Outdated
| @@ -533,12 +533,21 @@ func (s *state) updateSlurm(file string) (bool, error) { | |||
| RefreshStatusCode.WithLabelValues(file, fmt.Sprintf("%d", code)).Inc() | |||
| } | |||
|
|
|||
| hsum := newSHA256(data) | |||
| if s.lasthashCache != nil { | |||
There was a problem hiding this comment.
This is the wrong hash you check here. Should be lasthashSlurm.
Also in the bytes.Compare() below.
Hash was already performed on cache/vrp data this performs it for slurm as well, preventing uneeded refreshes when neither file have changed. Partial fix for bgp#114.
ties
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash was already performed on cache/vrp data
this performs it for slurm as well,
preventing uneeded refreshes when neither
file have changed.
Partial fix for #114.