bamhash #405
bamhash #405
Conversation
|
Only bamhash 1.0 seems to be available: https://github.com/bioconda/bioconda-recipes/blob/master/recipes/bamhash/meta.yaml |
|
can I just edit it? |
|
I think that might be the problem with many of the packages I just released.... is it possible to manually just edit the version in the xml file? |
|
A new conda package would be nice |
|
Ok, for this one I will make a new conda package, but what about the ones that have version behind the conda version? can I just edit the version number? |
|
Yes. Upgrading the package is OK. Remember if you do so increase the tool version number and remove the tool_dependencies.xml file. |
|
any convention I should follow when increasing the tool version? |
|
A version close or equal to the requirement version would be nice. —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread. |
|
The bioconda package is already 1.0. So, why do we need a new conda package for it. Am I missing something? |
|
Yeah, but the tool requirement is 1.1 :) |
|
Hi @HassanAmr, turns out the 1.1 version was correct: https://github.com/DecodeGenetics/BamHash/blob/dd15dee202b4d873768017b8959e8000d62ccf67/bamhash_checksum_common.h Can you create a new conda package for the latest commit or maybe we will get soon a new release: DecodeGenetics/BamHash#7 |
|
Hi @bgruening, So, this should work now? |
|
I get crazy: | /tmp/tmp5O2hMi/job_working_directory/000/10/tool_script.sh: line 9: bamhash_checksum_fastq: command not found |
|
Sorry, this one was obviously failing because I forgot to remove the dependecies xml file |
|
The tool_dependencies.xml has nothing to do with this, still not clear for me what happend, but everything is green so let's merge! |
|
My pleasure :) |
removed bamhash from the blacklist