Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inputProps types #29

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Add inputProps types #29

merged 3 commits into from
Jan 10, 2024

Conversation

dsnjunior
Copy link
Contributor

Changes

  • Add type-safety to inputProps

This solves #28

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0e00757

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
simple-stack-form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
simple-stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 3:02am

@dsnjunior dsnjunior changed the title Add Input props types Add inputProps types Jan 10, 2024
bholmesdev
bholmesdev approved these changes Jan 10, 2024
View reviewed changes
Copy link
Owner

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a switch back to using a typecast. Thanks for finding the deprecated package! Good changeset too

@bholmesdev bholmesdev merged commit 8052102 into bholmesdev:main Jan 10, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Merged
@dsnjunior dsnjunior deleted the fix/input-props-types branch January 11, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bholmesdev bholmesdev bholmesdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsnjunior @bholmesdev