Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use <span> to wrap fallback, prevent parsing issues #50

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

jonathantneal
Copy link
Contributor

This change replaces the <div> fallback wrapper with a <span> fallback wrapper as to allow it to be used within elements that only allow phrasing content, like <p>, <h1> etc.

See https://html.spec.whatwg.org/multipage/grouping-content.html#the-p-element

Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: 25bf781

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
simple-stack-stream Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
simple-stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 2:49am

@bholmesdev
Copy link
Owner

Ah, this is a good callout! So can any child be nested within a span? And does display: contents reset / normalize the styles of a span?

@jonathantneal
Copy link
Contributor Author

@bholmesdev, correct, any child can be nested within a span, and display: contents changes the display style from inline to contents.

Copy link
Owner

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good exspanation! I'm good with this 👍
Just add a changeset with a patch release (see contributing guide)

@bholmesdev
Copy link
Owner

Hey @jonathantneal just tagging in case the above was missed. Thanks!

@bholmesdev bholmesdev merged commit 0c88e91 into bholmesdev:main Mar 18, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants