Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple-stack-query #68

Merged
merged 27 commits into from
Jul 21, 2024
Merged

simple-stack-query #68

merged 27 commits into from
Jul 21, 2024

Conversation

bholmesdev
Copy link
Owner

@bholmesdev bholmesdev commented Jul 21, 2024

Changes

Introduces the new simple-stack-query package. This makes querying the DOM from an Astro component simple and safely scoped.

<button data-target={$('btn')}>Click me</button>
<!--data-target="btn-lsk34da"-->
<script>
$('btn').addEventListener('click' () => {});
</script>
  • Update vite-plugin-simple-scope to a TypeScript build process. This fixes type errors applying the plugin from an Astro config file.

  • Add packages/query

  • Add basic test using node:test. Update turbo and CI to run any test tasks across packages

  • Update packages/frame to use the latest astro-integration-kit conventions. Resolves type error with latest typescript version

  • I have read the "Making a Pull Request" section before making this PR.

Testing

Add basic test suite for $ scoping.

Docs

README and docs updates

Copy link

vercel bot commented Jul 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
simple-stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 9:59pm

Copy link

changeset-bot bot commented Jul 21, 2024

🦋 Changeset detected

Latest commit: b51e576

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
simple-stack-stream Patch
simple-stack-frame Patch
simple-stack-query Patch
vite-plugin-simple-scope Patch
simple-stack-form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bholmesdev bholmesdev merged commit 42c67d2 into main Jul 21, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant