Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ready -> $.ready #72

Merged
merged 2 commits into from
Jul 22, 2024
Merged

refactor: ready -> $.ready #72

merged 2 commits into from
Jul 22, 2024

Conversation

bholmesdev
Copy link
Owner

Changes

Move from a global ready() block to a $.ready() block. It's 10% more ugly, but 100% safer for namespace collisions!

Testing

Add client script to fixture for manual testing. TODO: e2e test

Docs

Update ready() references in docs.

Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 72e2630

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
simple-stack-query Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
simple-stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 0:08am

@bholmesdev bholmesdev merged commit 0051e5c into main Jul 22, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant