Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #286: Allow slide to close on videos #289

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Beagon
Copy link

@Beagon Beagon commented Sep 14, 2021

This should add the functionality proposed in #286

I've added a setting "touchVideoClosable" with default as false as to not interfere with legacy applications. The code itself has been added to touch-navigation.js.

I changed the name of mediaImage to mediaElement since it's not only about images anymore.

Of course also added the touchVideoClosable setting to README.md so the docs stay up to date!

@gingerchew
Copy link
Collaborator

@Beagon You still need to run the watch command, that will build everything into the dist folder. Other than that comment I made about the description on the README, everything looks good to me 😊

@Beagon
Copy link
Author

Beagon commented Sep 15, 2021

Hi @Frankie-tech,

I misread the CONTRIBUTING.md then. I saw the following line DO NOT commit changes in the dist directory, this files are created automatically. and didn't want to commit anything from dist :)

I've updated the PR.

@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Aug 31, 2022
@gingerchew gingerchew removed the wontfix label Sep 1, 2022
@stale
Copy link

stale bot commented Mar 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 6, 2023
@gingerchew gingerchew removed the wontfix label Mar 6, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Sep 16, 2023
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants