-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #286: Allow slide to close on videos #289
base: master
Are you sure you want to change the base?
Conversation
@Beagon You still need to run the |
Hi @Frankie-tech, I misread the CONTRIBUTING.md then. I saw the following line I've updated the PR. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This should add the functionality proposed in #286
I've added a setting "touchVideoClosable" with default as false as to not interfere with legacy applications. The code itself has been added to touch-navigation.js.
I changed the name of mediaImage to mediaElement since it's not only about images anymore.
Of course also added the touchVideoClosable setting to README.md so the docs stay up to date!