Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 fix: check user login #37

Merged
merged 2 commits into from
Oct 12, 2023
Merged

🐞 fix: check user login #37

merged 2 commits into from
Oct 12, 2023

Conversation

maxisam
Copy link
Contributor

@maxisam maxisam commented Oct 10, 2023

#35

@maxisam
Copy link
Contributor Author

maxisam commented Oct 10, 2023

well, it works fine here https://github.com/maxisam/dotnet-test-reporter/actions, and it doesn't hit the logger I add.

Here is the permission when it runs in my repo

image

But this is the permission when it ran in this repo

image

Maybe we need to add permission settings in the workflow?

https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

however, it works fine with my previous PR

@bibipkins
Copy link
Owner

@maxisam dont worry about the lack of permissions, it is ok. It is a common issue when developing GitHub actions using forked repositories. You can read more here

@bibipkins bibipkins merged commit 19b05f0 into bibipkins:main Oct 12, 2023
1 of 2 checks passed
@maxisam maxisam deleted the userlogin branch October 13, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants