Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase for checks #389

Open
wants to merge 16 commits into
base: development
Choose a base branch
from

Conversation

DanielC-N
Copy link
Contributor

@DanielC-N DanielC-N commented Dec 27, 2024

features added :

  • possibility to get a source/reference text
  • Reference link : when clicked, it scrolls directly to the correct verse and highlight it for 3 seconds.
  • checks :
    • : integrity checks : Checks for missing, duplicated, or out-of-order chapter/verse numbers.
    • : verse stats (with a reference/source text) : Detects short, long, or empty verses based on length comparison between source and target.
    • : unmatched punctuation : Detects unmatched punctuation pairs across verses (e.g., parentheses).
    • : repeated words and whitespaces : Detects consecutive repeated words and excessive whitespace in verses.

TODO :
Quotations detection report : check if the quote in the source language exists in the target language.

  • : Numbers : check if the numbers from the source translation are correctly reported in the target translation

@selvabenz
Copy link

selvabenz commented Dec 27, 2024

  1. Instead of no content available display choose a check from the checks dropdown
  2. Do need to load the source every time i open the project or is the selected source Bible saved? how do i know which source is loaded
  3. Can we keep the highlighted verse till the verse corrects it or can we retain the highlight for a longer period?
  4. Can we stick the checks heading while scrolling the mistakes?
    5. It says too long but detecting only the part of it MAT:6:8 updated PR has the solution
  5. Not taking the English ULT as a source
  6. Non of the IRV Bibles are working as source Bible for the checks
  7. Keep a provision for ignoring the checks with need the repeated words
  8. Finding the probelem in the Integrity Check but not taking it to the right reference as mentioned in the checks (When the verse number is not there, it is taken to the next chapter verse)
  9. Display the name of the source Bible loaded on the check panel
  10. Immediate update is not happening in the check after the correction

@DanielC-N
Copy link
Contributor Author

1 : Instead of no content available display choose a check from the checks dropdown 🟢 : this message is correctly displayed when no checks are selected.
3 : Can we keep the highlighted verse till the verse corrects it or can we retain the highlight for a longer period? 🟢 Now it last 5 seconds
5 : Not taking the English ULT as a source ❓ it does but it takes a long time because of the usfm => usj conversion
6 : Non of the IRV Bibles are working as source Bible for the checks ❓ same here.
8: Finding the probelem in the Integrity Check but not taking it to the right reference as mentioned in the checks (When the verse number is not there, it is taken to the next chapter verse) 🟢 Problem solved. When the verse doesn't exist, it takes you to the precedent verse, if it can't find it, it'll scroll to the chapter at least.
9 : Display the name of the source Bible loaded on the check panel 🟢
10 : Immediate update is not happening in the check after the correction 🟢

@selvabenz
Copy link

Thank you @DanielC-N for the fixes. The following issues found during the testing.

  1. In the first attempt of the checks the statistical verse is not shown/loading, after navigating to someother book then it shows the statistical verse
    image

  2. Short verse shown as too long verse in the checks result
    image
    image

  3. Integrity and repeated verse checks are not scrollable
    image

  4. Verse statistics: the reference link detects correctly in the checks, but in the editor it points to a different verse
    image

  5. Picking only half of the verse and it takes to the wrong verse number
    image
    image

  6. Can we put the verse number missing as a separate category? In the description of the checks it says empty verse
    image

@DanielC-N
Copy link
Contributor Author

  1. In the first attempt of the checks the statistical verse is not shown/loading, after navigating to someother book then it shows the statistical verse 🟢 : Fixed.
  2. Short verse shown as too long verse in the checks result 🟢 : Fixed.
  3. Integrity and repeated verse checks are not scrollable 🟢 : Fixed.
  4. Verse statistics: the reference link detects correctly in the checks, but in the editor it points to a different verse 🟢 : Fixed.
  5. Picking only half of the verse and it takes to the wrong verse number 🟢 : Fixed.
  6. Can we put the verse number missing as a separate category? In the description of the checks it says empty verse 🟠 : tbd in the bible-checker package.

@selvabenz
Copy link

Thank you @DanielC-N for the fixes. please check the mentioned issues

  1. In the integrity check the reference link is taking me to the particular chapter not to the verse mentioned in the link
    image

  2. The repeated verses and the excessive whitespace section not scrolling fully
    image

  3. Short verse shown as too long verse in the checks result : Not Fixed. it still shown as too long verse please check the screenshot
    image

  4. If the verse is missing or if the problem occurs in the verse before the heading then it takes the heading along with the verse
    image
    image

  5. Not important: the given time delay is displayed together. we can close the highlight of the previous when the latest is clicked
    image

@DanielC-N
Copy link
Contributor Author

  1. In the integrity check the reference link is taking me to the particular chapter not to the verse mentioned in the link. 🟠 : to discuss.
  2. The repeated verses and the excessive whitespace section not scrolling fully 🟢 : I've found a reliable fix for the scrolling problem AND now the headers of each checks stick to the top when you're scrolling!
  3. Short verse shown as too long verse in the checks result : Not Fixed. it still shown as too long verse please check the screenshot 🟠 : TBD in the next update of the package bible-checker
  4. If the verse is missing or if the problem occurs in the verse before the heading then it takes the heading along with the verse 🟢 : the link doesn't highlight anymore the headers. Is it ok like this?
    do_not_highlight_headers

5.Not important: the given time delay is displayed together. we can close the highlight of the previous when the latest is clicked 🟠 : this would be not efficient at all to code something like that ... I'll do that if we have time.

@selvabenz
Copy link

@DanielC-N , Could you check this error?

image

@DanielC-N
Copy link
Contributor Author

Can we stick the checks heading while scrolling the mistakes?

🟢 : now the headings stick to the top as you scroll

Do need to load the source every time i open the project or is the selected source Bible saved? how do i know which source is loaded

🟢 : now it shows wich resource has been selected.

Short verse shown as too long verse in the checks result : Not Fixed. it still shown as too long verse.

🟢 : now short and long verses should be displayed correctly

Can we put the verse number missing as a separate category? In the description of the checks it says empty verse

🟢 : now the missing verses are displayed in a separated category

Non of the IRV Bibles are working as source Bible for the checks (as well as some other resources

🟠 : we've discussed with @samueljd , it's a problem of convertion from USFM to USJ. It's in progress and should be fixed with Sam. I'll make sure the app doesn't crash.

@DanielC-N
Copy link
Contributor Author

last commit fixes/improvments :

  • FIX : add verse/chapter popup is no longer showing behind the check bar 🟢
  • FIX : the project reference name doesn't show the long version with the random numbers 🟢
  • UPDATE : now the source verse is shown in the check menu 🟢

Known bug :

  • some times the reference doesn't scroll correctly to the correct sentence in the reference text panel. 🟠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants