feat: add InvalidCharactersException

src/Biblys/Isbn/Exception/InvalidCharactersException.php

@@ -0,0 +1,21 @@
+<?php
+
+/*
+ * This file is part of the biblys/isbn package.
+ *
+ * (c) Clément Latzarus
+ *
+ * This package is Open Source Software. For the full copyright and license
+ * information, please view the LICENSE file which was distributed with this
+ * source code.
+ */
+
+namespace Biblys\Isbn\Exception;
+
+class InvalidCharactersException extends IsbnParsingException
+{
+  public function __construct($invalidCharacters)
+  {
+    parent::__construct("Cannot parse string with invalid characters: $invalidCharacters");
+  }
+}

src/Biblys/Isbn/Parser.php

@@ -13,20 +13,21 @@
 namespace Biblys\Isbn;
 
 use Biblys\Isbn\Exception\EmptyInputException;
+use Biblys\Isbn\Exception\InvalidCharactersException;
 use Biblys\Isbn\Exception\IsbnParsingException;
 
 class Parser
 {
     // FIXME: Create custom exceptions for each case
     const
-        ERROR_INVALID_CHARACTERS = 'Invalid characters in the code',
         ERROR_INVALID_LENGTH = 'Code is too short or too long',
         ERROR_INVALID_PRODUCT_CODE = 'Product code should be 978 or 979',
         ERROR_INVALID_COUNTRY_CODE = 'Country code is unknown',
         ERROR_CANNOT_MATCH_RANGE = "Cannot find any ISBN range matching prefix %s";
 
   /**
    * @throws EmptyInputException
+   * @throws InvalidCharactersException
    */
   public static function parse(string $input): ParsedIsbn
     {
@@ -37,8 +38,9 @@ public static function parse(string $input): ParsedIsbn
         $inputWithoutHyphens = self::_stripHyphens($input);
         $inputWithoutChecksum = self::_stripChecksum($inputWithoutHyphens);
 
-        if (!is_numeric($inputWithoutChecksum)) {
-            throw new IsbnParsingException(static::ERROR_INVALID_CHARACTERS);
+        $invalidCharacters = self::_extractInvalidCharacters($inputWithoutChecksum);
+        if (!empty($invalidCharacters)) {
+            throw new InvalidCharactersException($invalidCharacters);
         }
 
         $result = self::_extractProductCode($inputWithoutChecksum);
@@ -184,4 +186,13 @@ private static function _extractPublisherCode($input, $productCode, $countryCode
             sprintf(static::ERROR_CANNOT_MATCH_RANGE, $prefix)
         );
     }
+
+    /**
+     * @param string $inputWithoutChecksum
+     * @return string
+     */
+    public static function _extractInvalidCharacters(string $inputWithoutChecksum): string
+    {
+        return preg_replace('/[0-9]+/', '', $inputWithoutChecksum);
+    }
 }

tests/unit/ParserTest.php

@@ -22,4 +22,17 @@ public function testEmptyInput()
     Parser::parse($emptyValue);
   }
 
+  public function testInvalidCharacters()
+  {
+    // given
+    $stringWithInvalidCharacters = "978-1-2345-ABCD-0";
+
+    // then
+    $this->expectException(InvalidCharactersException::class);
+    $this->expectExceptionMessage("Cannot parse string with invalid characters: ABCD");
+
+    // when
+    Parser::parse($stringWithInvalidCharacters);
+  }
+
 }