Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Adding Dimitri Papadopoulos Orfanos to the list of contributors #157

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

DimitriPapadopoulos
Copy link
Collaborator

As suggested by @chrisfilo in #155.

@DimitriPapadopoulos DimitriPapadopoulos changed the title new contributor New contributor Feb 20, 2019
sappelhoff
sappelhoff previously approved these changes Feb 20, 2019
Remi-Gau
Remi-Gau previously approved these changes Feb 20, 2019
Copy link
Contributor

@chrisgorgo chrisgorgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your github username to CODEOWNER (see rule 3 at https://github.com/bids-standard/bids-specification/blob/master/DECISION-MAKING.md#rules).

@DimitriPapadopoulos
Copy link
Collaborator Author

This CODEOWNER file is almost empty, I can only find @chrisfilo is in it. I had had a look at the DECISION-MAKING document but the CODEOWNER file itself tells a different story:

This files [...] merely serves the purpose of notifying interested contributors when a new Pull Request that proposes changes to a particular file is submitted. If you would like to subscribe to such notifications (in a form of a Request for Review) please add your github username next to the file you want to monitor below.

@chrisgorgo
Copy link
Contributor

The rules are new - that's why the file is so empty.

Rule 3 was suggested by @choldgraf to incentivize people to add their names to CODEOWNERS, get automatic review invites and hopefully review more PRs.

@DimitriPapadopoulos
Copy link
Collaborator Author

DimitriPapadopoulos commented Feb 21, 2019

Can I add my name to an existing line or do I need to create a new line?

To be more specific, is the following line legal?

/src/01-common-principles.md @chrisfilo @DimitriPapadopoulos 

Or should I create a new line?

/src/01-common-principles.md @chrisfilo
/src/01-common-principles.md @DimitriPapadopoulos 

@chrisgorgo
Copy link
Contributor

You can add your name to an existing line. More details at https://help.github.com/en/articles/about-code-owners

Thanks!

@DimitriPapadopoulos
Copy link
Collaborator Author

I have added myself to CODEOWNERS.

@chrisgorgo chrisgorgo changed the title New contributor [MISC] Adding Dimitri Papadopoulos Orfanos to the list of contributors Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants