-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Define "modality" and clarify "data type" #592
Conversation
WDYT of also slightly updating the definition of "data types" to clarify that they're reflected in folder names? |
339b525
to
f567a09
Compare
That one was actually a bit harder to word, IMO. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the updated "Data type" definition. I think this will really help with the confusion about terminology.
Unless anyone raises any concerns about it, this PR should be good to merge tomorrow (5 days after second approval). |
I agree that it's good to be merged, it's a nice clarification. |
Closes #584.
Closes #586.
Reworded slightly from initial suggestion.