New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rf: Abstract out UTF8-enforcing stream handling #140

Open

effigies wants to merge 2 commits into bids-standard:main from effigies:rf/utf8stream

Contributor

effigies commented Jan 10, 2025

Split out from #139 to see if we can track down the resource leak piece by piece. Using CI since I can't reproduce it locally.

effigies added 2 commits

January 10, 2025 11:09


          rf: Abstract out UTF8-enforcing stream handling

c82177d


          chore(build): deno.lock

1e6d650

effigies force-pushed the rf/utf8stream branch from 770c9b2 to 1e6d650 Compare

January 10, 2025 16:09

effigies requested a review from nellh

January 10, 2025 16:13

effigies mentioned this pull request

rf: Read TSV files as streams #141

Open

Contributor Author

effigies commented Jan 10, 2025

This is ready for review.

Relatedly, do we want to replace the BIDSFileBrowser.text() as well, to keep behavior consistent across platforms? That can be a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet