Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bids-validator-web pack size. #1810

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Sep 20, 2023

npm pack uses gitignore relative to the workspace directory. Removed leading path for .next in gitignore.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.16% ⚠️

Comparison is base (ada255e) 85.74% compared to head (d0d3603) 83.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
- Coverage   85.74%   83.59%   -2.16%     
==========================================
  Files         132       92      -40     
  Lines        6728     3895    -2833     
  Branches     1548     1272     -276     
==========================================
- Hits         5769     3256    -2513     
+ Misses        851      541     -310     
+ Partials      108       98      -10     

see 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

@rwblair Is this good to go?

@rwblair rwblair merged commit 3c4a408 into bids-standard:master Nov 28, 2023
20 of 24 checks passed
@rwblair rwblair deleted the fix/gitignore-npm-pack branch August 7, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants