MNT: Update Python package configuration to use pyproject.toml #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1822 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 92 92
Lines 3895 3895
Branches 1272 1272
=======================================
Hits 3255 3255
Misses 542 542
Partials 98 98 ☔ View full report in Codecov by Sentry. |
|
Could I request a review from a Pythonista? Pinging @bids-standard/maintainers, but anybody should be able to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one in a series to factor out the Python validator from the Javascript validator.
Here we update the configuration to use
pyproject.toml, which will simplify any transitions we want to make away from setuptools+versioneer. We also are able to useversioneeras a build-time dependency instead of vendored, reducing a bit of noise in the repository.A future PR will add
bidsschematoolsas a dependency and replace the current functions with shims around that.