Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Un-define the unspecified Context.data #1823

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Oct 4, 2023

Introduced in #1797, but broken and made unnecessary by #1813 and bids-standard/bids-specification#1622.

This should fix one of the failing CI tests.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (92d459e) 83.56% compared to head (65bdbc8) 85.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
+ Coverage   83.56%   85.18%   +1.61%     
==========================================
  Files          92      132      +40     
  Lines        3895     6701    +2806     
  Branches     1272     1545     +273     
==========================================
+ Hits         3255     5708    +2453     
- Misses        542      884     +342     
- Partials       98      109      +11     
Files Coverage Δ
bids-validator/src/schema/context.ts 82.73% <ø> (ø)

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator Author

effigies commented Oct 4, 2023

@rwblair I think you're best placed to review this one.

@rwblair rwblair merged commit 0fb4ca3 into bids-standard:master Oct 4, 2023
21 of 24 checks passed
@effigies effigies deleted the fix/deno-build branch October 4, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants