Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Replace web validator with schema version and link to subdirectory build of the legacy validator #1929

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

nellh
Copy link
Member

@nellh nellh commented Apr 11, 2024

This moves the old validator to https://bids-standard.github.io/bids-validator/legacy and deploys the schema validator to https://bids-standard.github.io/bids-validator.

Adds a link to the old version.
image

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (a6f0756) to head (f810718).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
+ Coverage   85.58%   88.05%   +2.46%     
==========================================
  Files          91       39      -52     
  Lines        3768     2193    -1575     
  Branches     1207      272     -935     
==========================================
- Hits         3225     1931    -1294     
+ Misses        457      256     -201     
+ Partials       86        6      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh force-pushed the web-validator-ci branch 3 times, most recently from 1436ac9 to 081286a Compare April 12, 2024 17:47
@nellh nellh force-pushed the web-validator-ci branch from 081286a to c6a3afe Compare April 12, 2024 17:49
@nellh nellh changed the title fix: Push legacy validator to separate pages repo ENH: Replace web validator with schema version and link to subdirectory build of the legacy validator Apr 18, 2024
@nellh nellh force-pushed the web-validator-ci branch from 2644d22 to f810718 Compare April 18, 2024 16:21
@nellh nellh changed the title ENH: Replace web validator with schema version and link to subdirectory build of the legacy validator ci: Replace web validator with schema version and link to subdirectory build of the legacy validator Apr 18, 2024
@nellh nellh marked this pull request as ready for review April 18, 2024 17:31
@rwblair rwblair merged commit 3687c71 into bids-standard:master Apr 22, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants