Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import schema correctly from JSR #2111

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

effigies
Copy link
Collaborator

Starting with tests that should catch the error in the future.

@effigies effigies force-pushed the fix/schema-import branch 3 times, most recently from bfa8828 to d58fb6a Compare August 26, 2024 19:00
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (b005d9d) to head (2c7239f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
+ Coverage   85.69%   87.84%   +2.15%     
==========================================
  Files          91      133      +42     
  Lines        3782     6977    +3195     
  Branches     1220     1659     +439     
==========================================
+ Hits         3241     6129    +2888     
- Misses        455      754     +299     
- Partials       86       94       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwblair rwblair merged commit f3c4d2e into bids-standard:master Aug 26, 2024
17 of 19 checks passed
@effigies effigies deleted the fix/schema-import branch August 26, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants