Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate CITATION.cff #2116

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Aug 29, 2024

Dataset level check to validate citation.cff. Imports citation.cff json schema from @bids/schema package, convert citation.cff to json, and call ajv on it with stock ajv-formats.

Closes #1959.

@rwblair rwblair added the schema label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (e0ada04) to head (0c1b20a).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
bids-validator/src/validators/citation.ts 78.12% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2116      +/-   ##
==========================================
+ Coverage   85.72%   87.58%   +1.86%     
==========================================
  Files          91      134      +43     
  Lines        3782     7017    +3235     
  Branches     1220     1660     +440     
==========================================
+ Hits         3242     6146    +2904     
- Misses        454      776     +322     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bids-validator/src/validators/citation.ts Outdated Show resolved Hide resolved
bids-validator/src/validators/citation.ts Outdated Show resolved Hide resolved
bids-validator/src/validators/citation.ts Outdated Show resolved Hide resolved
@rwblair rwblair requested a review from effigies August 30, 2024 14:27
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failures should be resolved in #2117.

@effigies effigies changed the title Validate citation.cff feat: Validate CITATION.cff Aug 30, 2024
@effigies effigies merged commit 690a34a into bids-standard:master Aug 30, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CITATION.cff support
2 participants