Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass hedCode as subcode to group errors #2149

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Oct 3, 2024

cc @happy5214 In case you have any other suggestions.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.55%. Comparing base (0a2530b) to head (e118e49).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2149      +/-   ##
==========================================
+ Coverage   85.73%   87.55%   +1.82%     
==========================================
  Files          91      133      +42     
  Lines        3785     7008    +3223     
  Branches     1220     1657     +437     
==========================================
+ Hits         3245     6136    +2891     
- Misses        454      777     +323     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@happy5214
Copy link
Collaborator

Is subcode currently a valid parameter, and will it be added if it isn't?

@effigies effigies added the schema label Oct 4, 2024
@effigies
Copy link
Collaborator Author

effigies commented Oct 4, 2024

It is:

https://github.com/bids-standard/bids-validator/blob/f85d51f2b710be07137e6147388ed71461c369f5/bids-validator/src/types/issues.ts#L8-L19

Note this is for the schema validator, which has a new issue format.

@effigies effigies requested a review from rwblair October 4, 2024 14:53
@rwblair rwblair merged commit c52a671 into bids-standard:master Oct 9, 2024
19 checks passed
@effigies effigies deleted the rf/hed-to-bids branch October 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants