-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] refactor and update notebooks #802
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 85.76% 85.90% +0.13%
==========================================
Files 34 35 +1
Lines 3865 3882 +17
Branches 993 998 +5
==========================================
+ Hits 3315 3335 +20
- Misses 353 354 +1
+ Partials 197 193 -4
Continue to review full report at Codecov.
|
While running the notebooks I am getting a warning on one of the test datasets about its Is this intentional ? Maybe to test the CLI
|
No, the test dataset predates the derivatives release. |
Want a quick separate PR to fix this ? |
Sure. Might be good to keep the old one to test upgrade, and then use the upgraded one for smooth notebooking. |
Quick question so I don't non-sense in those examples. Is it the expected behavior that from bids import BIDSLayout
from bids.tests import get_test_data_path
import os
data_path = os.path.join(get_test_data_path(), "7t_trt")
print(f"Initializing layout with: {data_path}")
layout = BIDSLayout(data_path)
# relative path
layout.parse_file_entities("sub-01/ses-1/anat/sub-01_ses-1_T1map.nii.gz")
>>>
{'subject': '01',
'session': '1',
'suffix': 'T1map',
'datatype': 'anat',
'extension': '.nii.gz'}
# filename only
layout.parse_file_entities("sub-01_ses-1_T1map.nii.gz")
>>>
{'session': '1', 'suffix': 'T1map', 'extension': '.nii.gz'} That the datatype is not recovered from just the filename makes sense, but I am not sure why the subject is not parsed? Something I am missing? Similarly using |
Guessing that |
Suggested on the maintainers mattermost discussion.
New notebooks can be previewed here: https://github.com/Remi-Gau/pybids/tree/remi-update_notebooks/examples
TODO before merging
nb_black
calls from notebooks