Synchronize the modification of the ReferendumInfoFor state, especial…

…ly when the proposal ends.

pallets/vtoken-voting/src/lib.rs

@@ -927,6 +927,11 @@ pub mod pallet {
 			T::ControlOrigin::ensure_origin(origin)?;
 			Self::ensure_vtoken(&vtoken)?;
 
+			if new_status.is_over() {
+				let current_block_number = Self::get_agent_block_number(&vtoken)?;
+				Self::over_referendum_info_for(vtoken, poll_index, current_block_number);
+			}
+
 			// Update the referendum status in storage
 			ReferendumVoteStatusStore::<T>::insert(vtoken, poll_index, new_status.clone());
 			Self::deposit_event(Event::<T>::ReferendumStatusUpdated {
@@ -1652,18 +1657,26 @@ pub mod pallet {
 					ReferendumVoteStatusStore::<T>::insert(vtoken, poll_index, status);
 				}
 
-				ReferendumInfoFor::<T>::mutate(vtoken, poll_index, |maybe_info| match maybe_info {
-					Some(info) => {
-						if let ReferendumInfo::Ongoing(_) = info {
-							*info = ReferendumInfo::Completed(current_block_number);
-						}
-					}
-					None => {}
-				});
+				Self::over_referendum_info_for(vtoken, *poll_index, current_block_number);
 			}
 			ReferendumTimeoutV3::<T>::remove(vtoken, time_out_block_number);
 		}
 
+		fn over_referendum_info_for(
+			vtoken: CurrencyId,
+			poll_index: PollIndex,
+			current_block_number: BlockNumberFor<T>,
+		) {
+			ReferendumInfoFor::<T>::mutate(vtoken, poll_index, |maybe_info| match maybe_info {
+				Some(info) => {
+					if let ReferendumInfo::Ongoing(_) = info {
+						*info = ReferendumInfo::Completed(current_block_number);
+					}
+				}
+				None => {}
+			});
+		}
+
 		/// This function checks whether the user's tokens can be unlocked early based on their vote status
 		/// and the referendum result. It returns `true` if the user's vote is opposite to the referendum result,
 		/// indicating that early unlock is allowed.

pallets/vtoken-voting/src/vote.rs

@@ -747,3 +747,14 @@ impl Default for ReferendumVoteStatus {
 		ReferendumVoteStatus::Ongoing
 	}
 }
+
+impl ReferendumVoteStatus {
+	pub(crate) fn is_over(&self) -> bool {
+		match self {
+			ReferendumVoteStatus::Approved => true,
+			ReferendumVoteStatus::Rejected => true,
+			ReferendumVoteStatus::None => true,
+			ReferendumVoteStatus::Ongoing => false,
+		}
+	}
+}