Minq draft 21 #135
Merged
Minq draft 21 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QUIC implementations.
handshake-layer.go
Outdated
| @@ -173,10 +173,12 @@ func (h *HandshakeLayer) sendAlert(err Alert) error { | |||
|
|
|||
| func (h *HandshakeLayer) ReadMessage() (*HandshakeMessage, error) { | |||
| var hdr, body []byte | |||
| err := WouldBlock | |||
| err := error(nil) | |||
There was a problem hiding this comment.
Better: var err error
bifurcation
reviewed
Jul 25, 2017
conn.go
Outdated
| return HkdfExpandLabel(c.state.cryptoParams.Hash, tmpSecret, "exporter", hc, keyLength), nil | ||
| } | ||
|
|
||
| func (c *Conn) GetConnectionState() ConnectionState { |
There was a problem hiding this comment.
Nit: Think State() would be more aesthetic
| HandshakeState string // string representation of the handshake state. | ||
| CipherSuite CipherSuiteParams // cipher suite in use (TLS_RSA_WITH_RC4_128_SHA, ...) | ||
| PeerCertificates []*x509.Certificate // certificate chain presented by remote peer TODO([email protected]): implement | ||
| NextProto string // Selected ALPN proto |
There was a problem hiding this comment.
This is starting to look mighty similar to ConnectionParams. Is there some way to de-dup?
There was a problem hiding this comment.
Probably but I think too hard for this PR. See #136
frame-reader.go
Outdated
| @@ -2,8 +2,7 @@ | |||
| // This is used for both TLS Records and TLS Handshake Messages | |||
| package mint | |||
|
|
|||
| import ( | |||
| ) | |||
| import () | |||
There was a problem hiding this comment.
Nit: You can just delete this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.