-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding editor config and contributing instructions.
- Loading branch information
1 parent
de708d4
commit f953b19
Showing
3 changed files
with
65 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
root = true | ||
|
||
[*] | ||
charset = utf-8 | ||
|
||
[*.java] | ||
indent_style = space | ||
indent_size = 4 | ||
trim_trailing_whitespace = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# How to contribute | ||
|
||
I like to encourage you to contribute to the repository. | ||
This should be as easy as possible for you but there are a few things to consider when contributing. | ||
The following guidelines for contribution should be followed if you want to submit a pull request. | ||
|
||
## How to prepare | ||
|
||
* You need a [GitHub account](https://github.com/signup/free) | ||
* Submit an [issue ticket](https://github.com/anselmh/CONTRIBUTING.md/issues) for your issue if the is no one yet. | ||
* Describe the issue and include steps to reproduce if it's a bug. | ||
* Ensure to mention the earliest version that you know is affected. | ||
* If you are able and want to fix this, fork the repository on GitHub | ||
|
||
## Make Changes | ||
|
||
* In your forked repository, create a topic branch for your upcoming patch. (e.g. `feature/issue-22-enhance-four-candles` or `bugfix/issue-42-crash-when-laughing`) | ||
* Usually this is based on the master branch. | ||
* Create a branch based on master; | ||
* `git checkout master` | ||
* `git checkout -b feature/issue-22-enhance-four-candles` | ||
* Please avoid working directly on the `master` branch. | ||
* Make sure you stick to the coding style that is used already. | ||
* Make use of the `.editorconfig` to ensure you're IDE is setup with the right formatting rules | ||
* Make commits of logical units and describe them properly. | ||
* Check for unnecessary whitespace with `git diff --check` before committing. | ||
|
||
* If possible, submit tests to your patch / new feature so it can be tested easily. | ||
* Assure nothing is broken by running all the tests. | ||
|
||
## Submit Changes | ||
|
||
* Push your changes to a topic branch in your fork of the repository. | ||
* Open a pull request to the original repository and choose the right original branch you want to patch. | ||
_Advanced users may install the `hub` gem and use the [`hub pull-request` command](https://github.com/defunkt/hub#git-pull-request)._ | ||
* If not done in commit messages (which you really should do) please reference and update your issue with the code changes. But _please do not close the issue yourself_. | ||
_Notice: You can [turn your previously filed issues into a pull-request here](http://issue2pr.herokuapp.com/)._ | ||
* Even if you have write access to the repository, do not directly push or merge pull-requests. Let another team member review your pull request and approve. | ||
|
||
# Additional Resources | ||
|
||
* [General GitHub documentation](http://help.github.com/) | ||
* [GitHub pull request documentation](http://help.github.com/send-pull-requests/) | ||
* [Read the Issue Guidelines by @necolas](https://github.com/necolas/issue-guidelines/blob/master/CONTRIBUTING.md) for more details |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters