Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamps documentation #30

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Revamps documentation #30

merged 1 commit into from
Jan 3, 2024

Conversation

shreyansh-g24
Copy link
Contributor

Checklist

  • I have made corresponding changes to the documentation
  • I have verified the generated JSDoc comments
  • I have updated the types definition of modified exports
  • I have added jest tests for newly added changes
  • I have verified the functionality in some of the neeto web-apps.

@shreyansh-g24 shreyansh-g24 self-assigned this Dec 27, 2023
…Adds documentation for missing object functions.
@shreyansh-g24 shreyansh-g24 force-pushed the 29-revamp-documentation branch from 63f633c to a0875ba Compare December 27, 2023 16:36
@shreyansh-g24
Copy link
Contributor Author

@AbhayVAshokan _a Please review. I have not removed the development and build instructions since it is a public repository.

@shreyansh-g24 shreyansh-g24 changed the title 29 revamp documentation Revamp documentation Dec 27, 2023
@shreyansh-g24 shreyansh-g24 changed the title Revamp documentation Revamps documentation Dec 27, 2023
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had a mis-comunication on what was expected out of this issue. I was expecting this documentation to be refactored in the same format as https://github.com/bigbinary/neeto-commons-frontend/pull/898.

Merging this PR since it resolves the primary issue of missing docs. I'll raise a new issue for refactoring the documentation.

@AbhayVAshokan AbhayVAshokan merged commit b437552 into main Jan 3, 2024
1 check passed
@AbhayVAshokan AbhayVAshokan deleted the 29-revamp-documentation branch January 3, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some functions like isNotPresent are not documented in readme
2 participants