Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend audit #1040

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Frontend audit #1040

merged 2 commits into from
Mar 14, 2024

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented Mar 14, 2024

Description

  • Updated: packages and configurations

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.
- [ ] I have verified the functionality in some of the neeto web-apps.
~~- [ ] I have added the necessary label (patch/minor/major - If package publish
is required).~

Reviewers

@AbhayVAshokan _a

@gaagul
Copy link
Contributor Author

gaagul commented Mar 14, 2024

@AbhayVAshokan

“postcss”: “8.4.31",
“postcss-import”: “15.1.0",
“postcss-loader”: “7.3.3",
“postcss-preset-env”: “9.2.0",
“@babel/core”: “7.23.2"
“@babel/eslint-parser”: “7.22.15",
“@babel/plugin-transform-runtime”: “7.23.2",

these packages are causing issues while building storybook, which i was not able to figure out completely could you please take a look at it.

@AbhayVAshokan
Copy link
Member

The issue is with the incompatible storybook and babel versions. We shall fix this in a separate issue. Merging this PR to unblock #1024.

@neetodeploy neetodeploy bot had a problem deploying to neeto-editor-pr-1040 March 14, 2024 12:26 Failure
@AbhayVAshokan AbhayVAshokan added the patch Releases small requests or bug fixes. label Mar 14, 2024
@AbhayVAshokan AbhayVAshokan merged commit b87c366 into main Mar 14, 2024
@AbhayVAshokan AbhayVAshokan deleted the 1027-fix-audit-failures branch March 14, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all the audit failures
2 participants