Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor specific CSS variables #1248

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Editor specific CSS variables #1248

merged 6 commits into from
Oct 22, 2024

Conversation

praveen-murali-ind
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind commented Oct 22, 2024 •
edited
Loading

Fixes #1243

Description

  • Added editor-specific CSS variables.
  • Removed border from image container.
  • Removed border from video container.
  • Used rem instead of px font font sizes for accessibility.

Tested in KB

Screenshot 2024-10-22 at 4 56 24 PM Screenshot 2024-10-22 at 4 55 29 PM

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@praveen-murali-ind _A

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1248 October 22, 2024 09:09 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1248 October 22, 2024 09:38 Inactive
@praveen-murali-ind praveen-murali-ind changed the title Editor specific CSS variables Editor specific CSS variables Oct 22, 2024
@praveen-murali-ind praveen-murali-ind changed the title Editor specific CSS variables Editor specific CSS variables Oct 22, 2024
@praveen-murali-ind
Copy link
Contributor Author

@AbhayVAshokan _A Please review.

@praveen-murali-ind praveen-murali-ind added the patch Releases small requests or bug fixes. label Oct 22, 2024
@AbhayVAshokan AbhayVAshokan merged commit 85b4bbe into main Oct 22, 2024
@AbhayVAshokan AbhayVAshokan deleted the 1243-neeto-editor-specific-CSS-variables branch October 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@AbhayVAshokan AbhayVAshokan

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the feasibility of using NeetoEditor-specific CSS variables and customizations
2 participants
@praveen-murali-ind @AbhayVAshokan