Adds support for size prop in Editor and EditorContent components. #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AbhayVAshokan _a please review. |
AbhayVAshokan
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Looks good. @praveen-murali-ind _a I am assigning this to you so that you can add necessary CSS overrides when size is large.
|
@AbhayVAshokan The sizing styles can be addressed as a separate issue. |
praveen-murali-ind
approved these changes
Oct 22, 2024
praveen-murali-ind
deleted the
1247-add-support-for-sizing-in-editor-and-editoroutput
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1247
Description
Checklist
I have verified the functionality in some of the neeto web-apps.is required).
Reviewers