Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates header links script to handle duplicate header texts. #1263

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Updates header links script to handle duplicate header texts. #1263

merged 2 commits into from
Nov 7, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Nov 7, 2024 •
edited
Loading

Fixes #1262

Description

  • Updated header links script to handle duplicate header texts and append an index to make it unique.
  • Renamed navigableHeadings to headerLinks since that name is better and have the same name in NeetoKB.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

@AbhayVAshokan AbhayVAshokan merged commit 27750b8 into main Nov 7, 2024
@AbhayVAshokan AbhayVAshokan deleted the 1262-handle-duplicate-headings-in-the-header-links-script branch November 7, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@AbhayVAshokan AbhayVAshokan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle duplicate headings in the header links script.
2 participants
@deepakjosp @AbhayVAshokan