Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements missing features of the Codeblock component in NeetoWebsite custom codeblock component. #1278

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Implements missing features of the Codeblock component in NeetoWebsite custom codeblock component. #1278

merged 7 commits into from
Nov 29, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Nov 22, 2024 •
edited
Loading

Fixes #1275

Description

  • Updated codeblock line highlight to support BB blogs.
  • Updated code block script to inject a copy button to the UI.
  • Added line numbers to the codeblock.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1278 November 22, 2024 12:59 Inactive
@deepakjosp deepakjosp self-assigned this Nov 22, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1278 November 22, 2024 13:03 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1278 November 25, 2024 04:37 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1278 November 25, 2024 07:12 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Nov 25, 2024
@deepakjosp
Copy link
Contributor Author

@praveen-murali-ind _a please review.

@deepakjosp deepakjosp changed the title Implements missing features of the Codeblock componnet in NeetoWebsite custom codeblock component. Implements missing features of the Codeblock component in NeetoWebsite custom codeblock component. Nov 26, 2024
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review. Let's merge once Praveen reviews the UI.

AbhayVAshokan
AbhayVAshokan reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Line numbers are not rendered unless it is highlighted.

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1278 November 26, 2024 08:24 Inactive
AbhayVAshokan
AbhayVAshokan approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praveen-murali-ind _a

@praveen-murali-ind
Copy link
Contributor

Looking into this.

praveen-murali-ind
praveen-murali-ind reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakjosp _a I have added the styles for the code block. Please check.

Screenshot 2024-11-28 at 5 21 17 PM

@deepakjosp deepakjosp merged commit e501e7b into main Nov 29, 2024
@deepakjosp deepakjosp deleted the 1275-implement-missing-features-of-the-codeblock-in-neetowebsite-custom-codeblock-component branch November 29, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveen-murali-ind praveen-murali-ind praveen-murali-ind left review comments

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@deepakjosp deepakjosp

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement missing features of the CodeBlock in NeetoWebsite custom CodeBlock component.
3 participants
@deepakjosp @praveen-murali-ind @AbhayVAshokan