Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates a similar shouldUpdate function, FastField internally uses and calls the external shouldUpdate along with it to prevent the component not re-rendering in a few scenarios. #1291

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Dec 11, 2024

Fixes https://github.com/bigbinary/neeto-molecules/issues/1795

Description

NeetoForm:
image

NeetoRunner:
image

NeetoCal:
image

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

…d calls the external shouldUpdate along with it to prevent the component not re-rendering in a few scenarios.
@deepakjosp deepakjosp changed the title Creates a similar shouldUpdate funciton fast field internally uses and calls the external shouldUpdate along with it to prevent the component not re-rendering in a few scenarios. Creates a similar shouldUpdate function, FastField internally uses and calls the external shouldUpdate along with it to prevent the component not re-rendering in a few scenarios. Dec 11, 2024
@deepakjosp deepakjosp self-assigned this Dec 11, 2024
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Dec 12, 2024
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned deepakjosp Dec 12, 2024
@AbhayVAshokan AbhayVAshokan merged commit ff6d2df into main Dec 12, 2024
@AbhayVAshokan AbhayVAshokan deleted the 1795-error-message-not-shown-on-saving-empty-email-body-template-in-email-notifications branch December 12, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants