Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistency with attachment previews #913

Merged
merged 9 commits into from
Oct 30, 2023

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented Oct 18, 2023

Description

  • Fixed: inconsistency with attachment previews

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.

  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@AbhayVAshokan _a

@gaagul gaagul requested a review from AbhayVAshokan as a code owner October 18, 2023 10:46
@gaagul gaagul added the patch Releases small requests or bug fixes. label Oct 18, 2023
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-913 October 18, 2023 10:47 Inactive
@gaagul
Copy link
Contributor Author

gaagul commented Oct 18, 2023

@AbhayVAshokan I have updated the behavior of the attachments preview, Please let me know if you feel any other method is better.

@unnitallman unnitallman temporarily deployed to neeto-editor-pr-913 October 19, 2023 18:29 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-913 October 24, 2023 10:47 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-913 October 24, 2023 15:35 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-913 October 25, 2023 09:04 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-913 October 25, 2023 09:54 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-913 October 27, 2023 15:35 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-913 October 28, 2023 12:27 Inactive
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaagul _a added support for PDFs and TXTs. Please verify on your end as well.

@neetogit-bot neetogit-bot bot assigned gaagul and unassigned AbhayVAshokan Oct 28, 2023
@gaagul gaagul merged commit 9b76c90 into main Oct 30, 2023
@gaagul gaagul deleted the 907-issues-with-attachments-preview branch October 30, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to show the preview for other types of attachments Inconsistency with the attachment previews
4 participants