Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preview for image in EditorContent #950

Merged
merged 7 commits into from
Dec 6, 2023

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented Nov 27, 2023

Description

  • Added: preview for image in EditorContent

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.

  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@AbhayVAshokan _a

@gaagul gaagul added the patch Releases small requests or bug fixes. label Nov 27, 2023
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-950 November 27, 2023 04:06 Inactive
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update the color of the modal backdrop to neetoUI
  • Fix the positioning of the modal inside panes
  • Fix the positioning of the close button
  • If target="_blank" is provided, the preview need not be shown.

@gaagul _a

src/components/EditorContent/ImagePreview.jsx Outdated Show resolved Hide resolved
@neetogit-bot neetogit-bot bot assigned gaagul and unassigned AbhayVAshokan Nov 27, 2023
@gaagul
Copy link
Contributor Author

gaagul commented Nov 27, 2023

Converting the Pr to draft, will continue the work after completing the priority work in neeto-course-web.

@gaagul gaagul marked this pull request as draft November 27, 2023 11:38
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-950 December 1, 2023 08:24 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-950 December 6, 2023 04:38 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-950 December 6, 2023 13:04 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-950 December 6, 2023 18:04 Inactive
@gaagul gaagul marked this pull request as ready for review December 6, 2023 18:04
@gaagul gaagul merged commit d06760c into main Dec 6, 2023
@gaagul gaagul deleted the 942-image-preview-in-editor-content branch December 6, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User should be able to see a full scale version of the image
4 participants