Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-label to editor content #972

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Added aria-label to editor content #972

merged 2 commits into from
Dec 19, 2023

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented Dec 19, 2023

Description

  • Added: aria-label attribute to editor content

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.
- [ ] I have verified the functionality in some of the neeto web-apps.

  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@VarunSriram99 _a

@gaagul
Copy link
Contributor Author

gaagul commented Dec 19, 2023

@VarunSriram99 I have added "aria-label" to editor, please review the changes and let me know if more attributes are needed.

@VarunSriram99
Copy link

@gaagul can you add the proper aria-role labels as well?

@VarunSriram99
Copy link

VarunSriram99 commented Dec 19, 2023

@gaagul additionally adding a role, aria-disabled and aria-controls (if applicable) is recommended so that the elements are more easily accessible.

@gaagul
Copy link
Contributor Author

gaagul commented Dec 19, 2023

@gaagul can you add the proper aria-role labels as well?

Is "aria-roledescription" = "editor" enough or do you have something specific in mind?

@gaagul additionally adding a role, aria-disabled, aria-role and aria-controls (if applicable) is recommended so that the elements are more easily accessible.

By role did you mean the "aria-roledescription" ?

@VarunSriram99
Copy link

VarunSriram99 commented Dec 19, 2023

@gaagul can you add the proper aria-role labels as well?

Is "aria-roledescription" = "editor" enough or do you have something specific in mind?

@gaagul additionally adding a role, aria-disabled, aria-role and aria-controls (if applicable) is recommended so that the elements are more easily accessible.

By role did you mean the "aria-roledescription" ?

@gaagul
We can add the role attribute to specify the aria-role.
role="textbox" should be good enough. Adding roledescrption can be useful as well in case of screen readers.

We can also add in labels like

  role="textbox"
  aria-multiline="true"
  aria-labelledby="labelId"
  aria-required="true" (based on required prop)
  aria-disabled="false" (based on disabled prop)
  aria-controls="controls-id" (optional for the toolbar controls)

@gaagul
Copy link
Contributor Author

gaagul commented Dec 19, 2023

We can also add in labels like

Thanks for the clarification, I will add the necessary labels.

@gaagul _a

@neetogit-bot neetogit-bot bot assigned gaagul and unassigned VarunSriram99 Dec 19, 2023
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-972 December 19, 2023 16:53 Inactive
@gaagul gaagul merged commit dc02a0e into main Dec 19, 2023
@gaagul gaagul deleted the 969-add-aria-labels branch December 19, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aria-* labels to make editor more accessible
3 participants