Prevents calling hide tooltip if already destroyed. (#2341)

* Removed the unsupported props from the Tooltip. * Updated the instance.hide in tooltip to run only if the instance is not destroyed.
bigbinary · Oct 10, 2024 · b5b1af0 · b5b1af0
1 parent 4570882
commit b5b1af0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/src/components/Dropdown/index.jsx b/src/components/Dropdown/index.jsx
@@ -226,10 +226,6 @@ Dropdown.propTypes = {
    * To specify the content to be rendered inside the Dropdown.
    */
   children: PropTypes.node,
-  /**
-   * To specify whether the Dropdown menu width needs to be set to auto or not.
-   */
-  autoWidth: PropTypes.bool,
   /**
    * To provide external classnames to Dropdown target wrapper.
    */
@@ -273,10 +269,6 @@ Dropdown.propTypes = {
    * To provide custom modifiers to Dropdown component.
    */
   dropdownModifiers: PropTypes.array,
-  /**
-   * To specify whether the Dropdown should be multilevel.
-   */
-  isMultiLevel: PropTypes.bool,
   /**
    * <div class="neeto-ui-tag neeto-ui-tag--size-small neeto-ui-tag--style-outline neeto-ui-tag--style-danger mb-2">
    * Removed

diff --git a/src/components/Tooltip/index.jsx b/src/components/Tooltip/index.jsx
@@ -23,7 +23,10 @@ const Tooltip = ({
 
   if (hideAfter > 0) {
     localProps["onShow"] = instance =>
-      setTimeout(() => instance.hide(), hideAfter);
+      setTimeout(
+        () => !instance.state?.isDestroyed && instance.hide(),
+        hideAfter
+      );
   }
 
   useEffect(() => {

diff --git a/stories/Components/Dropdown.stories.jsx b/stories/Components/Dropdown.stories.jsx
@@ -203,7 +203,7 @@ const MultiDropdownWithClickTrigger = args => {
 
   return (
     <div className="flex h-80 items-start">
-      <Dropdown {...args} isMultiLevel label="Dropdown">
+      <Dropdown {...args} label="Dropdown">
         <Menu>
           {listItems.map((item, idx) => (
             <MenuItem.Button key={idx}>{item}</MenuItem.Button>
@@ -246,7 +246,7 @@ const MultiDropdownWithHoverTrigger = args => {
 
   return (
     <div className="flex h-80 items-start">
-      <Dropdown {...args} isMultiLevel label="Dropdown">
+      <Dropdown {...args} label="Dropdown">
         <Menu>
           {listItems.map((item, idx) => (
             <MenuItem.Button key={idx}>{item}</MenuItem.Button>