Handle invalid value prop in DateTimePicker #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/bigbinary/neeto-ui into 2068-datetimepicker-handle-invalid-input
There was a problem hiding this comment.
@farhanlatheef _a As discussed in the standup, I tested these changes locally in neetoPlanner and found that they are not working as expected. The API is getting triggered indefinitely.
|
@farhanlatheef CI is red. |
josephmathew900
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
LGTM.
@farhanlatheef _a Please add the description also, it is required for CHANGELOG.md. Please add the description and merge the PR.
yedhink
reviewed
Feb 5, 2024
There was a problem hiding this comment.
@josephmathew900 @farhanlatheef Noticed the following. Lemme know your thoughts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the value prop is invalid date or date string, the value is converted to null.
Checklist
- [ ] I have made corresponding changes to the documentation.- [ ] I have added properdata-cyanddata-testidattributes.patch/minor/major- If package publishis required).
Reviewers