Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding allowClear #2078

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Allow overriding allowClear #2078

merged 3 commits into from
Feb 6, 2024

Conversation

ajmaln
Copy link
Contributor

@ajmaln ajmaln commented Feb 5, 2024

Description
Added: Support for allowClear prop in DatePicker to be false

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@ajmaln ajmaln added the patch Releases small requests or bug fixes. label Feb 5, 2024
@ajmaln ajmaln self-assigned this Feb 5, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-pr-2078 February 5, 2024 15:14 Inactive
@ajmaln ajmaln marked this pull request as ready for review February 5, 2024 15:24
@ajmaln
Copy link
Contributor Author

ajmaln commented Feb 5, 2024

@josephmathew900 _a Please review

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned ajmaln Feb 5, 2024
josephmathew900
josephmathew900 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephmathew900 josephmathew900 merged commit 26746c5 into main Feb 6, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2077-allow-overriding-allow-clear branch February 6, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow allowClear prop in DatePicker to be false
2 participants
@ajmaln @josephmathew900