Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added internationalization support for antd component #2265

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Added internationalization support for antd component #2265

merged 1 commit into from
Jul 20, 2024

Conversation

josephmathew900
Copy link
Contributor

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2265 July 19, 2024 03:29 Inactive
@josephmathew900 josephmathew900 force-pushed the 2264-add-internationalization-support-for-antd-components branch 2 times, most recently from c094e3d to 7c733dd Compare July 19, 2024 03:31
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2265 July 19, 2024 03:31 Inactive
@josephmathew900 josephmathew900 force-pushed the 2264-add-internationalization-support-for-antd-components branch from 7c733dd to 6ae5552 Compare July 19, 2024 03:32
@josephmathew900 josephmathew900 changed the title Added internationalization support antd component Added internationalization support for antd component Jul 19, 2024
@josephmathew900
Copy link
Contributor Author

@gaagul _a please review.

@gaagul
Copy link
Contributor

gaagul commented Jul 20, 2024 •
edited
Loading

@josephmathew900 _A I have tested the changes here is a demo: https://gaagul-gigi.neetorecord.com/watch/d0de63e2-0e40-432e-b2da-00326c98814b

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned gaagul Jul 20, 2024
@josephmathew900 josephmathew900 added the patch Releases small requests or bug fixes. label Jul 20, 2024
@josephmathew900 josephmathew900 merged commit 9afda1f into main Jul 20, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2264-add-internationalization-support-for-antd-components branch July 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add internationalization support antd component
2 participants
@josephmathew900 @gaagul