Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the getNow prop to the date picker so that the now will make use of dayjs that has timezone set. #2361

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Set the getNow prop to the date picker so that the now will make use of dayjs that has timezone set. #2361

merged 2 commits into from
Nov 1, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Oct 30, 2024 •
edited
Loading

Description

  • Updated NeetoDatePicker to accept getNow as an optional prop and replaces the generateConfig.getNow with the external getNow when availabel.
  • set the getNow prop with value dayjs which will return the current time in the set timezone.

Demo: https://deepak-jose.neetorecord.com/watch/ace8d14e-ca06-42ac-aaa9-affe51287990

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot had a problem deploying to neeto-ui-1f4k-pr-2361 October 30, 2024 07:09 Failure
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Oct 30, 2024
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

@deepakjosp
Copy link
Contributor Author

The changes required in neeto-datepicker: bigbinary/neeto-datepicker#9

@AbhayVAshokan AbhayVAshokan merged commit 35202f9 into main Nov 1, 2024
1 check passed
@AbhayVAshokan AbhayVAshokan deleted the 2344-now-button-in-the-date-time-picker-is-ignoring-the-set-timezone branch November 1, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@AbhayVAshokan AbhayVAshokan

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Now button in the date time picker is ignoring the set timezone.
2 participants
@deepakjosp @AbhayVAshokan